New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed centered image caption toolbar on IE11. #6136

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Apr 12, 2018

Description

In the image block we had a CSS rule for centered images that should not be applied to the toolbar and when applied caused a problem in IE11.
This PR fixes the rule.
Fixes: #5792
I tried to replicate the problem and find similar rules in other blocks but it looks like this problem only affects images.

How Has This Been Tested?

In IE11, add an image block, center it, verify the toolbar continue to display correctly in the center.

@jorgefilipecosta jorgefilipecosta added this to the 2.7 milestone Apr 12, 2018

@jorgefilipecosta jorgefilipecosta self-assigned this Apr 12, 2018

@mtias mtias merged commit 6187723 into master Apr 12, 2018

2 checks passed

codecov/project 44.44% remains the same compared to 14bb454
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the fix/image-toolbar-ie11 branch Apr 12, 2018

@jorgefilipecosta jorgefilipecosta changed the title from Fixed cantered image caption toolbar on IE11. to Fixed centered image caption toolbar on IE11. Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment