New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline "code" background when part of multiselection. #6143

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
3 participants
@mtias
Contributor

mtias commented Apr 12, 2018

Small improvement to how we display inline code within a multi-selected group.

Before:
image

After:
image

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 12, 2018

Nice, seems good to go 👍👍

@mtias mtias merged commit 0a084ad into master Apr 12, 2018

2 checks passed

codecov/project 44.44% remains the same compared to 4d8466e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the update/multi-select-code-color branch Apr 12, 2018

@@ -37,6 +37,10 @@
background: $light-gray-200;
font-family: $editor-html-font;
font-size: 14px;
.is-multi-selected & {

This comment has been minimized.

@aduth

aduth Apr 12, 2018

Member

Should the RichText component have awareness of multi-selection, or should this style be applied from the block list stylesheet?

This comment has been minimized.

@mtias

mtias Apr 12, 2018

Contributor

I pondered about this a bit, not entirely sure. But this seemed clearer to express.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment