New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover Areas: Small improvements #6148

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Apr 12, 2018

Sorry for the bad PR title, this is mostly to address some comments from @aduth here #6101 (review)

related to #6101

Testing instructions

  • Check that the hover areas are working properly.

@youknowriad youknowriad self-assigned this Apr 12, 2018

@youknowriad youknowriad requested a review from aduth Apr 12, 2018

@youknowriad youknowriad merged commit 9c21156 into master Apr 13, 2018

2 checks passed

codecov/project 44.44% (+0%) compared to 0a084ad
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the update/small-improvements-hover-areas branch Apr 13, 2018

@@ -57,6 +57,6 @@ const withHoverAreas = ( WrappedComponent ) => {
}
return WithHoverAreasComponent;
};
} );

This comment has been minimized.

@aduth

aduth Apr 13, 2018

Member

createHigherOrderComponent expects a second name argument. Though it's technically optional, helps when debugging through React DevTools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment