New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the editor switch mode shortcut work from anywhere. #6149

Merged
merged 1 commit into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@afercia
Contributor

afercia commented Apr 12, 2018

This PR makes the keyboard shortcut mod+shift+alt+m work from anywhere, even when inside a contenteditable area, input field, and textarea. See also #5847 / #6144.

Keyboard users will benefit from being able to switch editor mode at any time, even when editing content. For example, when they edit content in "Code" mode, focus is in a textarea and now they can quickly switch to "Visual" mode and again to "Code" mode and so on just pressing Command (or Ctrl on WIndows) +shift+alt+m.

A further improvement would be trying to keep the caret position in the Code mode in the block being edited, and vice-versa, as recently implemented in the old WordPress editor.

Fixes #5716

@afercia afercia requested a review from youknowriad Apr 12, 2018

@youknowriad

Nice 👍

@afercia afercia merged commit 1b57afd into master Apr 12, 2018

2 checks passed

codecov/project 44.44% remains the same compared to 0a084ad
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@afercia afercia deleted the update/switch-editor-mode-shortcut-global branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment