New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove emoji script #6151

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Projects
None yet
3 participants
@iseulde
Member

iseulde commented Apr 12, 2018

Description

Fixes #2799.

How Has This Been Tested?

Ensure the emoji scripts are removed from the Gutenberg pages.

@iseulde iseulde added this to the 2.7 milestone Apr 12, 2018

@iseulde iseulde added the [Type] Bug label Apr 12, 2018

@iseulde iseulde requested a review from WordPress/gutenberg-core Apr 12, 2018

@aduth

aduth approved these changes Apr 12, 2018

@pento

pento approved these changes Apr 12, 2018

I'm fine with removing it for now, the behaviour is obviously causing issues. We'll need to figure out how to make it work for 5.0, though.

@iseulde

This comment has been minimized.

Member

iseulde commented Apr 13, 2018

@pento Sure. This is a quick fix to prevent further saving of emoji as images. In the RichText component we can probably do something similar to what we do in the old editor now, and for the rest of the page we could maybe look into a React custom renderer to inject the images. I'm not sure introducing the script on a page with React is a good idea, so this seems like a good step in the right direction.

@iseulde iseulde merged commit 75c2f9d into master Apr 13, 2018

2 checks passed

codecov/project 44.44% remains the same compared to 1b57afd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the remove/emoji-script branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment