Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Edit Post: Update advanced settings phrases #6162
@gziolo thanks, seems to me all hte occurrences are covered
It's important for the sidebar region to always have the same name. Elements with a
These regions have been implemented to split the whole editor in 3 areas, so users can quickly move to the top toolbar, the content area, the sidebar. For this reason, the sidebar should always have the same name. Changing the label depending on which content is displayed in the sidebar would be confusing. For example, see how VoiceOver exposes landmark regions:
This is the main reason why previously everything, including the button in the menu, was named "advanced settings". That way, users were able to look for an "advanced settings" landmark at any time, without too much overhead.
Now that the menu item refers to "block", things are a bit different. Maybe the simpler option is to use just "Editor settings" for both the document and block sidebar.
I can do that, sounds good. What about plugins sidebar? They use the same region but have a different name. Any thoughts?