New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line break in permalink #6169

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
4 participants
@Rahmon
Contributor

Rahmon commented Apr 13, 2018

Description

Permalink element break line with long text strings.

Closes #5437

How Has This Been Tested?

This has been tested with "npm test" and manually on Chrome and Firefox.

Screenshots

screenshot from 2018-04-13 08-16-19

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@Rahmon Rahmon changed the title from Fix break line in permalink to Fix line break in permalink Apr 13, 2018

@danielbachhuber danielbachhuber requested a review from karmatosed Apr 14, 2018

@pento

This comment has been minimized.

Member

pento commented Apr 16, 2018

@Rahmon: I just merged a fairly large change the permalinks UI into master, could I get you to test master and confirm that this issue still occurs?

@Rahmon

This comment has been minimized.

Contributor

Rahmon commented Apr 16, 2018

@pento: this issue still happen.

screenshot from 2018-04-15 22-03-19

@pento

This comment has been minimized.

Member

pento commented Apr 16, 2018

Ah, I see. Thank you for confirming that. 🙂

@pento pento added this to the 2.7 milestone Apr 17, 2018

@pento pento merged commit fc15186 into WordPress:master Apr 17, 2018

2 checks passed

codecov/project 44.37% remains the same compared to aaa5464
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment