New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility standards reference and context #6179

Merged
merged 2 commits into from Apr 16, 2018

Conversation

Projects
None yet
4 participants
@moorscode
Contributor

moorscode commented Apr 14, 2018

Description

During WordCamp London me and @rianrietveld came up with this approach to help provide a reminder to the accessibility standards, and also to add a direct connection to them to make sure the creator of a PR knows how to retrieve the needed information and context.

It is very easy to forget about this concern if it is not explicitly mentioned.
And the specific needs related to it are also quite complex, so a reference should be a big help in checking what the standards actually are.

While adding this, it seemed the logical step to also add standards references to the other items already present in the template.

How has this been tested?

Not applicable.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@atimmer

👍🏻

Update PULL_REQUEST_TEMPLATE.md
We use `npm run` in other places in the docs.

@gziolo gziolo merged commit 0de347f into WordPress:master Apr 16, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment