New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify left positioning of .components-notice-list and .edit-post-header #6211

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
2 participants
@johnwatkins0
Contributor

johnwatkins0 commented Apr 16, 2018

Description

This PR resolves #6171 by positioning the elements with the .components-notice-list and .edit-post-header classes to the right of the admin sidebar when it's displaying and not collapsed.

Currently, the editor-left mixin assumes the sticky-menu class is always present on the body element, but that's not the case when the sidebar + the admin menu are taller than the window. This change simply removes .sticky-menu from the selector, and the low specificity allows the .auto-fold class to take precence when it exists (i.e., when the sidebar is collapsed).

How has this been tested?

Visually verified at various screen widths with the admin sidebar both expanded and collapsed.

Screenshots

Before

before

After

after

Types of changes

Small changes to two Sass files.

@youknowriad

Fixes the issue for me. Thanks 👍

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented Apr 17, 2018

I'm seeing a bug on the top position of the notices on small viewports but it's unrelated
screen shot 2018-04-17 at 09 10 31

@youknowriad youknowriad merged commit 77eba26 into WordPress:master Apr 17, 2018

2 checks passed

codecov/project 43.94% remains the same compared to 9966a96
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment