New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link format toolbar z-index issue. #6229

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
2 participants
@jorgefilipecosta
Member

jorgefilipecosta commented Apr 17, 2018

Description

This PR fixes a z-index issue with the link format toolbar.

How has this been tested?

Create a paragraph. Add a link to it. Verify the link format toolbar is visible in all resolutions and above block controls.

Screenshots

After:
image
image

Before:
screen shot 2018-04-17 at 22 08 49
screen shot 2018-04-17 at 22 09 05

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 18, 2018

Nice this seems good! 👍 👍

Can you give my branch, #6217, a quick spin? I don't know that I fixed this issue in that branch, but I'm fixing some other issues with the same UI. I think with both these merged in, links will be in a much better place.

@jorgefilipecosta

This comment has been minimized.

Member

jorgefilipecosta commented Apr 18, 2018

Hi @jasmussen thank you for the review! It looks like your PR was already merged so I can not add the commit there. I rebased this and checked that this has no collisions with your PR and changes here continue to be valid and necessary.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 18, 2018

Awesome, if you can make it for 2.7, 👍👍

@jorgefilipecosta jorgefilipecosta merged commit 4bb6047 into master Apr 18, 2018

2 checks passed

codecov/project 43.83% remains the same compared to 7e25ca2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jorgefilipecosta jorgefilipecosta deleted the fix/hyperlink-z-index-issues branch Apr 18, 2018

@jorgefilipecosta jorgefilipecosta added this to the 2.7 milestone Apr 18, 2018

nuzzio added a commit to nuzzio/gutenberg that referenced this pull request Apr 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment