New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with columns appender #6237

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented Apr 18, 2018

This fixes an issue where the default appender in columns would have a border, and the wrong font. This was introduced as part of the input style consistency PR. Increasing selector specificity fixes this.

Before:

screen shot 2018-04-18 at 10 56 26

After:

screen shot 2018-04-18 at 10 57 09

馃憢 don't mind the yellow background color, I'm experimenting with editor styles :D

Fix regression with columns appender
This fixes an issue where the default appender in columns would have a border, and the wrong font. This was introduced as part of the input style consistency PR. Increasing selector specificity fixes this.

@jasmussen jasmussen self-assigned this Apr 18, 2018

@jasmussen jasmussen requested a review from youknowriad Apr 18, 2018

@youknowriad

LGTM 馃憤

@youknowriad youknowriad merged commit 79c00f9 into master Apr 18, 2018

2 checks passed

codecov/project 43.85% remains the same compared to d6d950a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/column-appender branch Apr 18, 2018

@phpbits

This comment has been minimized.

phpbits commented Apr 20, 2018

@jasmussen I can't find the changes where the blocks.BlockEdit were disabled on blocks inside the columns. I thought it's this one, would you mind pointing me to the right direction?

I've created this plugin : http://wordpress.org/plugins/block-options/ and the options I've added are not showing on the inner columns anymore. Thanks!

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 20, 2018

Cool plugin!

I don't know that I'm the right one to ask (at least I don't know how to answer). If you can, can you ask your question in the WordPress core editor chat? https://make.wordpress.org/chat/ 鈥 channel: #core-editor 鈥 you can ping me, username @joen in slack, and I'll boost your signal.

@phpbits

This comment has been minimized.

phpbits commented Apr 20, 2018

Thanks @jasmussen :) Really appreciated!

nuzzio added a commit to nuzzio/gutenberg that referenced this pull request Apr 25, 2018

Fix regression with columns appender (WordPress#6237)
This fixes an issue where the default appender in columns would have a border, and the wrong font. This was introduced as part of the input style consistency PR. Increasing selector specificity fixes this.

@mtias mtias modified the milestone: 2.8 May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment