New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Show image blocks with external URLs and support resizing #6240

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@youknowriad
Contributor

youknowriad commented Apr 18, 2018

related #5812

This PRs fixes the image block when using an external URL (the images were not showing) and also adds resizing support using the inspector controls to these images.

Testing instructions

  • Check that the images in the demo content show up properly
  • Check that you can resize them using the inspector controls
  • Check that resizing using the inspector controls also work for media library inserted images.

@youknowriad youknowriad added this to the 2.7 milestone Apr 18, 2018

@youknowriad youknowriad self-assigned this Apr 18, 2018

@youknowriad youknowriad requested review from noisysocks and jasmussen Apr 18, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Apr 18, 2018

Nice! works for me 👍 👍

@youknowriad youknowriad merged commit cee2df5 into master Apr 18, 2018

2 checks passed

codecov/project 43.83% (-0.01%) compared to 0815bc4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/image-block-with-external-url branch Apr 18, 2018

@noisysocks

This comment has been minimized.

Member

noisysocks commented Apr 18, 2018

👍 code looks good. Thanks for fixing that up, Riad!

@@ -221,84 +219,85 @@ class ImageBlock extends Component {
const isResizable = [ 'wide', 'full' ].indexOf( align ) === -1 && ( ! viewPort.isExtraSmall() );
const getInspectorControls = ( imageWidth, imageHeight )=> (

This comment has been minimized.

@noisysocks

noisysocks Apr 18, 2018

Member

Huh, weird that the linter didn't complain about the missing space here.

This comment has been minimized.

@noisysocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment