Links: Add ref="noreferrer noopener" for target="_blank" links #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Feature] Rich Text
noisysocks
previously requested changes
Apr 23, 2018
There was a problem hiding this comment.
Thanks for adding this! 😍
Looks like there's a regression with unsetting this toggle:
- Insert a link with Open in a new window turned ON
- Preview the post. Notice that the link opens in a new tab
- Edit the link and turn Open in a new window OFF
- Preview the post. Notice that the link still opens in a new tab
| @@ -744,7 +744,8 @@ export class RichText extends Component { | |||
| if ( ! anchor ) { | |||
| this.removeFormat( 'link' ); | |||
| } | |||
| this.applyFormat( 'link', { href: formatValue.value, target: formatValue.target }, anchor ); | |||
| const { value: href, ...params } = formatValue; | |||
| this.applyFormat( 'link', { href, ...params }, anchor ); | |||
There was a problem hiding this comment.
Feels like we could avoid some friction if we named the attribute href instead of value, but eh.
youknowriad
dismissed
noisysocks’s stale review
Good catch, it looks like TinyMCE only patches the format instead of resetting it. Updated by explicitly passing null values.
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
…ress#6316) * Links: Add ref="noreferrer noopener" for target="_blank" links * Fix resetting the "open in new tab" option
4 tasks
|
Is it possible to change this behavior with a plugin, and if so, how? noreferrer can cause issues for affiliate programs tracking the link. TinyMCE used to use add both noreferrer and noopener but has since switched to only adding noopener. Core has a filter that can be used to switch to just using noopener but how can this be done in Gutenberg? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6186
This PR adds ref="noreferrer noopener" to target="_blank" links for security reasons.
Testing instructions
ref="noreferrer noopener"is added to the link in the code editor.