Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with high contrast indicator in Edge #6373

Merged
merged 1 commit into from May 10, 2018

Conversation

@jasmussen
Copy link
Contributor

commented Apr 24, 2018

This rejiggers the Switch high contrast mode a bit, to enhance how it works in Edge. Edge has an obscure bug where it overlays the outline on the SVG, regardless of outline-offset. This fixes that, and makes the switch work in high contrast mode in IE, Edge and Firefox on Windows. Chrome on Windows does not support high contrast mode.

The switch still works unchanged on Chrome and Firefox MacOS.

Screenshots of Edge:

screen shot 2018-04-24 at 10 23 43

screen shot 2018-04-24 at 10 19 03

Fix issue with high contrast indicator in Edge
This rejiggers the Switch high contrast mode a bit, to enhance how it works in Edge. Edge has an obscure bug where it overlays the outline on the SVG, regardless of outline-offset. This fixes that, and makes the switch work in high contrast mode in IE, Edge and Firefox on Windows. Chrome on Windows does not support high contrast mode.

The switch still works unchanged on Chrome and Firefox MacOS.

@jasmussen jasmussen self-assigned this Apr 24, 2018

@jasmussen jasmussen requested a review from gziolo Apr 24, 2018

@gziolo gziolo requested a review from WordPress/gutenberg-core Apr 26, 2018

@karmatosed karmatosed merged commit 2af2c2f into master May 10, 2018

2 checks passed

codecov/project 44.04% remains the same compared to e05a542
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/edge-switch-indicator branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.