Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Components: Implement Button as assigning ref via forwardRef #6527
This pull request seeks to bring in React's (new as of 16.3.0)
Verify that there are no regressions in the behavior of button, particularly in the two places where its
If memory serves me,
PostPermalink was the only component using
focus(). I tested editing post permalinks and there are no regressions.
Hmm, unfortunately seems to be another instance of Enzyme lagging behind React: airbnb/enzyme#1604
Was able to implement the workaround for the buttons tests themselves, but will have to see what I can do for other components which render buttons (failing Autocomplete tests, for example).