New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Add global guard against ZWSP in E2E content retrieval #6710

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@aduth
Member

aduth commented May 11, 2018

Extracted from #6467

This pull request seeks to add a globally-considered failing case for zero-width space characters present in end-to-end test content. An instance of this was discovered in #6467 (#6467 (comment)), and while the issue itself is resolved there, the test is not specific to the writing flow behaviors and should be considered broadly.

Testing instructions:

Verify end-to-end tests pass:

npm run test-e2e

@aduth aduth requested a review from WordPress/gutenberg-core May 31, 2018

@iseulde

iseulde approved these changes Jun 1, 2018

Sounds good to me.

@aduth aduth merged commit dd182dd into master Jun 1, 2018

2 checks passed

codecov/project 44.03% remains the same compared to d70ec18
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@aduth aduth deleted the add/e2e-zwsp-guard branch Jun 1, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment