New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Fail E2E tests when uncaught page error occurs #6713

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
3 participants
@aduth
Member

aduth commented May 11, 2018

This pull request seeks to enhance end-to-end tests to fail a test if any uncaught page errors occur during their execution.

Testing instructions:

Fortunately, there are no existing page failures in existing tests. You can introduce one by adding this to edit-post/index.js in your local branch:

setTimeout( () => {
	throw new Error( 'Oops!' );
}, 1 );

Then verify that the end-to-end tests fail:

npm run test-e2e

Related resources:

@noisysocks

Excellent!

@noisysocks noisysocks merged commit e17e56b into master May 29, 2018

2 checks passed

codecov/project 44.03% remains the same compared to d70ec18
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noisysocks noisysocks deleted the add/e2e-test-failure-uncaught-error branch May 29, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment