New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Update all tests which depend on editor #6738

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
3 participants
@gziolo
Member

gziolo commented May 14, 2018

Description

Follow up for #6731. An alternative solution to #6730.

This PR removes the dependency on the editor module code from blocks tests. To accomplish that I updated all tests to work without all editor hooks applied. I moved also tests related to InnerBlocks component to be located next to the source code. Finally, I moved code that tests multiple hooks applied to the newly introduced integration folder.

How has this been tested?

npm test

Types of changes

Refactoring for tests, no production code changed.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo self-assigned this May 14, 2018

@gziolo gziolo requested review from youknowriad and WordPress/gutenberg-core May 14, 2018

@youknowriad

LGTM 👍

@gziolo gziolo merged commit 67bf325 into master May 21, 2018

2 checks passed

codecov/project 44.18% remains the same compared to c45d6bd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/blocks-tests-no-editor-deps branch May 21, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment