Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/block icon alignment #6765

Merged
merged 5 commits into from May 16, 2018
Merged

Conversation

ajitbohra
Copy link
Member

Description

BlockIcon is off by 2px

How has this been tested?

Manually

Screenshots

block-icon

Types of changes

Non-breaking

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@noisysocks noisysocks added Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system labels May 16, 2018
@Soean
Copy link
Member

Soean commented May 16, 2018

Fixes #5404

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! Ship it!

@gziolo gziolo merged commit 6da2a0d into WordPress:master May 16, 2018
@gziolo gziolo added this to the 2.9 milestone May 16, 2018
@ajitbohra ajitbohra deleted the fix/block-icon-alignment branch May 18, 2018 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants