Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Popover: Refactor popover to clarify computations #6799
and support setting max-width/max-height depending on the available space
This will fix the issues we have where popovers are cut over the edges of the browser window by adapting the height/width of the popovers.
Still having trouble with a z-index issue at the moment.
Excellent work on this refactor. Testing the popover it looks like a big improvement.
There is some debugging that could be made like understand why withSafeTimeout interferes with z-index if time allows in the future. But given the number of issues closed and the noticeable improvements for the user that we have I feel we should get it in soon so we can test it more before the next release.