New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish menus and focus styles #6812

Merged
merged 4 commits into from May 23, 2018

Conversation

Projects
None yet
5 participants
@jasmussen
Contributor

jasmussen commented May 18, 2018

This fixes a regression in menu focus styles that was introduced as part of some focus fixes to the movers way back.

It also fixes #6734, as it changes how the shortcuts are spelled out.

screen shot 2018-05-18 at 09 37 06

screen shot 2018-05-18 at 09 37 12

@jasmussen jasmussen self-assigned this May 18, 2018

@jasmussen jasmussen requested review from noisysocks, iseulde and WordPress/gutenberg-core May 18, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented May 18, 2018

Nice, More Menu is getting fixed. I'm not sure why those keyboard shortcuts were updated in the first place, so I will leave review to others :)

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 18, 2018

I think I also fixed the Block More Menu btw.

@karmatosed

👍 on design review

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 22, 2018

Rebased, and fixed an issue as a result of the buttons refactor. I think this is ready to go.

@jasmussen jasmussen requested a review from WordPress/gutenberg-core May 22, 2018

[ COMMAND ]: '',
[ SHIFT ]: isMac ? '⇧shift' : 'Shift',
[ SHIFT ]: isMac ? 'Shift' : 'Shift',

This comment has been minimized.

@iseulde

iseulde May 22, 2018

Member

This could be simplified to [ SHIFT ]: 'Shift',.

[ ALT ]: isMac ? '⌥option' : 'Alt',
[ CTRL ]: isMac ? '⌃control' : 'Ctrl',
[ ALT ]: isMac ? 'Option' : 'Alt',
[ CTRL ]: isMac ? 'Ctrl' : 'Ctrl',

This comment has been minimized.

@iseulde

iseulde May 22, 2018

Member

This could be simplified to [ CTRL ]: 'Ctrl',.

jasmussen added some commits May 18, 2018

Polish menus and focus styles
This fixes a regression in menu focus styles that was introduced as part of some focus fixes to the movers way back.

It also fixes #6734, as it changes how the shortcuts are spelled out.
@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 23, 2018

Addressed feedback, rebased, and merging if the checks pass. Thanks!

@jasmussen jasmussen merged commit 5f3c7f8 into master May 23, 2018

2 checks passed

codecov/project 46.31% remains the same compared to 75d3c35
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/menu-focus branch May 23, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment