New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the Title uses the same max-width as blocks #6813

Merged
merged 1 commit into from May 19, 2018

Conversation

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented May 18, 2018

During the development of #6438, it was noted that the Title does not use the same $content-width as a block. Which means if you want to change the width of titles and blocks per these instructions, you actually have to compensate for the title.

This PR fixes that. The title and normal nonwide blocks now have exactly the same width.

Test that:

  • The width of the title doesn't regress in mobile or desktop breakpoitns
  • the widht of the title block and post permalink matches that of a normal block

screen shot 2018-05-18 at 10 13 27

@jasmussen jasmussen self-assigned this May 18, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core May 18, 2018

@karmatosed

Looks good to me, thanks for catching this.

@karmatosed karmatosed merged commit b541282 into master May 19, 2018

2 checks passed

codecov/project 46.43% remains the same compared to 1b1ca4b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@karmatosed karmatosed deleted the polish/max-width branch May 19, 2018

}
/*.editor-post-permalink {

This comment has been minimized.

@aduth

aduth May 24, 2018

Member

Commented code should be removed.

@jasmussen jasmussen referenced this pull request May 25, 2018

Merged

Remove comment #6951

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment