New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try unifying all the media blocks placeholder under a unique component #6820

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
4 participants
@youknowriad
Contributor

youknowriad commented May 18, 2018

This PR adds a MediaPlaceholder component used in all the media blocks to unify their UI. #5456

This brings dropzones to audio/video blocks. At the moment the image cover-image and gallery blocks do not show the "URL" input because if we do so we need to rething the "editing" flow of these blocks. (How to you update the URL? Should we change the edit button in the toolbar to trigger the placeholder even if the media is there (like audio/video)?).

So this refactors to use the same component while keeping the same features/flow.

Testing instructions

  • Test the different flows of the media blocks (uploading, dragging, media library, editing...)

@youknowriad youknowriad self-assigned this May 18, 2018

@youknowriad youknowriad requested a review from gziolo May 18, 2018

@gziolo gziolo requested a review from karmatosed May 21, 2018

@karmatosed

Looks great, thanks.

@youknowriad youknowriad merged commit 16dd8b2 into master May 22, 2018

2 checks passed

codecov/project 46.39% (-0.03%) compared to 1fce057
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the try/unify-media-placeholder branch May 22, 2018

@gziolo

This comment has been minimized.

Member

gziolo commented May 22, 2018

🎉

@jasmussen jasmussen referenced this pull request May 24, 2018

Closed

Implement File block #6805

11 of 11 tasks complete

mirka added a commit to mirka/gutenberg that referenced this pull request May 26, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment