New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: withRehydratation → withRehydration #6862

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
3 participants
@noisysocks
Member

noisysocks commented May 21, 2018

Renames withRehydratation to withRehydration in a backwards compatible way.

To test:

  1. Open or close the sidebar
  2. Refresh the page—the sidebar should remain opened or closed
@youknowriad

LGTM 👍

@gziolo gziolo added this to the 3.0 milestone May 21, 2018

*/
export function withRehydratation( reducer, reducerKey, storageKey ) {
deprecated( 'wp.data.withRehydratation', {
version: '3.1',

This comment has been minimized.

@gziolo

gziolo May 21, 2018

Member

It should be rather 3.2. It should be also included in the Deprecated document: https://github.com/WordPress/gutenberg/blob/master/docs/reference/deprecated.md.

@noisysocks noisysocks merged commit e245ea2 into master May 21, 2018

2 checks passed

codecov/project 46.43% (-0.01%) compared to 5a91c0a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noisysocks noisysocks deleted the fix/rehydration-typo branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment