New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct min-width for the ChromePicker popover #6863

Merged
merged 3 commits into from May 22, 2018

Conversation

Projects
None yet
4 participants
@pento
Member

pento commented May 21, 2018

Description

This PR addresses #6750, by overriding the min-width of the popover container of the ChromePicker widget.

This special case is required, as ChromePicker hardcodes it's width, with no apparent option for overriding it.

Note: #5962 suggested an alternate method for fixing this, but it appears that's how it was originally implemented, but it caused other problems, so was removed in #3120.

Screenshots

Before

Screenshot of colour picker element with incorrect width

After

Screenshot of colour picker element with corrected width

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@pento pento added this to the 3.0 milestone May 21, 2018

@pento pento requested a review from WordPress/gutenberg-core May 21, 2018

@gziolo

gziolo approved these changes May 21, 2018

Code looks good, but it needs to be confirmed by one of the designers.

@mtias

This comment has been minimized.

Contributor

mtias commented May 21, 2018

This is fine, we still need to evaluate if we go with this picker or rebuilt it ourselves (from its primitives). There were accessibility issues as it stands.

@karmatosed karmatosed self-requested a review May 21, 2018

@pento pento merged commit 3d897ea into master May 22, 2018

2 checks passed

codecov/project 46.43% remains the same compared to 6fc2152
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pento pento deleted the fix/6750-chrome-picker-popover-width branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment