New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lost applied formats #6865

Merged
merged 2 commits into from May 21, 2018

Conversation

Projects
None yet
4 participants
@youknowriad
Contributor

youknowriad commented May 21, 2018

This PR reverts #6455 and add an e2e test to ensure the format changes are persisted properly.

Testing instructions

  • Add a paragraph block
  • Select some text and apply any format (bold, italic, link)
  • Save and refresh
  • The formats are still applied.

closes #6854 #6850

@youknowriad youknowriad self-assigned this May 21, 2018

@youknowriad youknowriad requested a review from iseulde May 21, 2018

@youknowriad

This comment has been minimized.

Contributor

youknowriad commented May 21, 2018

@iseulde I reverted the change but if you think there's something else to do (keep the change and tweak it) please do

@gziolo

gziolo approved these changes May 21, 2018

I confirm that this PR properly reverts changes introduced.

e2e test looks nice 👍

@iseulde

I'm fine with reverting and looking for a better fix.

@youknowriad youknowriad merged commit 3122002 into master May 21, 2018

2 checks passed

codecov/project 46.44% (+0.01%) compared to 0b9de9f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/formatting-lost branch May 21, 2018

@danielbachhuber danielbachhuber added this to the 3.0 milestone May 22, 2018

@youknowriad youknowriad referenced this pull request May 23, 2018

Merged

Avoid change in RichText when possible #6872

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment