New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excerpt textarea fixed height overflow bug #6874

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
2 participants
@vtrpldn
Contributor

vtrpldn commented May 21, 2018

Description

Removed excerpt textarea default value of 80px and margin-bottom 0 override.

How has this been tested?

QA with BrowserStack major desktop and mobile browsers.

Screenshots

excerpt-height-fixed

Types of changes

Fix #6873

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@danielbachhuber danielbachhuber added this to the 3.0 milestone May 21, 2018

@danielbachhuber

Thanks @vtrpldn! Looking back at the history, the fixed height was introduced in 8b45f3f#diff-28fc8c78aa2f868468d1c457d811b8dd (over a year ago). This seems like a reasonable fix to me.

@danielbachhuber danielbachhuber merged commit 5a91c0a into WordPress:master May 21, 2018

2 checks passed

codecov/project 46.44% remains the same compared to ce61b59
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vtrpldn vtrpldn deleted the vtrpldn:fix/excerpt-textarea-height branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment