New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up shared block tests #6884

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
2 participants
@noisysocks
Member

noisysocks commented May 22, 2018

Minor clean-up of some shared block tests.

  • Shared blocks use integer IDs, not string UUIDs
  • expect() assertions should happen in an it(), not a describe()
Improve shared block tests
- Shared blocks take integer IDs, not string UUIDs
- expect() assertions should happen in an it(), not a describe()
@gziolo

gziolo approved these changes May 22, 2018

👍

@gziolo gziolo added this to the 3.0 milestone May 22, 2018

@gziolo gziolo merged commit 1fce057 into master May 22, 2018

2 checks passed

codecov/project 46.43% remains the same compared to 3d897ea
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/selector-tests branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment