New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions with Button component after PostCSS #6888

Merged
merged 2 commits into from May 22, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented May 22, 2018

This issue fixes a few teensy regressions that were introduced with the refactor of the button component. Notably:

  • The colors of default, light, and midnight primary buttons was wrong. This was probably inherited from before, but was made clear with the new styles
  • The colors of the primary buttons were too dark
  • The candy-striped publishing gradient broke

Gradient before:

gradient before

Gradient after:

gradient after

jasmussen added some commits May 22, 2018

Fix issues with primary colors
The standard, light, and midnight themes were off. And the colors were too dark.
Fix "busy" gradient
the past gradient did not loop horizontally, and was an actual gradient, where as it was supposed to use candy stripes that were solid.

@jasmussen jasmussen self-assigned this May 22, 2018

@jasmussen jasmussen requested a review from youknowriad May 22, 2018

@youknowriad

LGTM 👍

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 22, 2018

🤘

@jasmussen jasmussen merged commit d78133f into master May 22, 2018

2 checks passed

codecov/project 46.39% remains the same compared to 16dd8b2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/button-regressions branch May 22, 2018

@danielbachhuber danielbachhuber added this to the 3.0 milestone May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment