Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve title "block" so it works with and without editor styles #6909
The title block is tricky. Because it's not a block. It also relies on a
It's very complicated, but the short of it is, in order to look and behave like a block, the CSS styles are somewhat complex. I recently introduced a regression as a result of trying to make it more theme style friendly. But the fix to that regression caused a regression in turn to the theme styles.
This PR tries to fix all that. The title now looks and behaves like a block, on all breakpoints, and it's easily stylable by theme editor styles. For example, with the following CSS rules, you can have an editor that fills the entire canvas:
Or you can even apply a specific pixel or percent value.
Previously you had to make special rules JUST for the title block, so as to match the other elements.
One less cool thing about this PR, and suggestions are welcome, is that it introduces a new div, and renames a CSS class (to follow bem rules of hierarchy). I wish there was a different way.
referenced this pull request
May 29, 2018
This all looks good to me and I think making the title more like other blocks is
Just some comment/code quality cleanups requested from me; once they're done this is good to merge so I say approved.