Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
URL Input: Use Popover instead of custom positionning and custom modals #6911
This PR updates the URL Input and the format toolbar to use the
Actually, scratch that. I don't know what it was that I was seeing, but a hard reload made this work. Stellar work!
Can you move the popover upwards about 10px? that would make it feel more connected with the link.
Seeing the following error when adding the target attribute, and I don't see this error in master?
Thanks for the review, I didn't notice the
selectedNodeId. Good advice