New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inbetweenserter regression #6913

Merged
merged 3 commits into from May 23, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented May 23, 2018

This fixes two regressions as part of the newly introduced inbetweenserter PR.

  1. The z-index was off. That's been fixed.
  2. The inbetweenserter would linger if you clicked to insert, then clicked away from the empty paragraph.

Thanks Riad for help!

@jasmussen jasmussen self-assigned this May 23, 2018

@jasmussen jasmussen requested a review from youknowriad May 23, 2018

@youknowriad

LGTM 👍

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 23, 2018

The tests are passing on my commandline, but travis is angry. Going to pick up my daughter from school and see if they pass when I come back, and then merge.

jasmussen and others added some commits May 23, 2018

Fix regression with inbetweenserter
There was a good reason for the z index, so this reverts it.
@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 23, 2018

Rebased to force Travis to take another look. Will merge if passes.

@youknowriad youknowriad merged commit 7ad3fa4 into master May 23, 2018

2 checks passed

codecov/project 46.14% (-0.01%) compared to 64d3355
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/inbetweenserter-regression branch May 23, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment