New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Andrew feedback #6930

Merged
merged 2 commits into from May 24, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented May 24, 2018

This PR addresses feedback in #6314 (review) and #6496 (review).

Specifically, it:

  • refines the image classes saved
  • moves the TinyMCE table handle styles to the main stylesheet, since they are global
  • cleans up an animation that was astray seemingly

Thank you Andrew, appreciate it!

jasmussen added some commits May 24, 2018

Address feedback for image block
This changes the syntax a little bit.
Address feedback fro table block
This cleans up where the global table handle styles are stored, and rearranges an animation that seemed astray.

@jasmussen jasmussen self-assigned this May 24, 2018

@jasmussen jasmussen requested a review from aduth May 24, 2018

@aduth

aduth approved these changes May 24, 2018

Looks good 👍

@jasmussen jasmussen merged commit 3cfaf1d into master May 24, 2018

2 checks passed

codecov/project 46.14% (+0%) compared to 321be98
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/andrew-feedback branch May 24, 2018

@jasmussen jasmussen added this to the 3.0 milestone May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment