New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix some intermittent E2E test failures #6971

Merged
merged 2 commits into from May 28, 2018

Conversation

Projects
None yet
2 participants
@noisysocks
Member

noisysocks commented May 28, 2018

The multi-block-selection and managing-links E2E tests seem to fail intermittently in Travis CI but always pass locally for me.

My guess is that it's because we're sometimes calling asynchronous functions without waiting (using await) for the result.

It's difficult to verify that this PR fixes the issue. An 'All checks have passed' is good—but we might have just gotten lucky 🤷‍♂️

@noisysocks noisysocks changed the title from Attempt to fix managing-links E2E test to Attempt to fix some intermittent E2E test failures May 28, 2018

@pento

pento approved these changes May 28, 2018

👍🏻 Let's see if this helps.

@noisysocks noisysocks merged commit 5c8c274 into master May 28, 2018

2 checks passed

codecov/project 46.44% remains the same compared to bdcbf71
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noisysocks noisysocks deleted the fix/e2e-tests branch May 28, 2018

@noisysocks noisysocks added this to the 3.0 milestone May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment