New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blob: Extract new `blob` package out of utils module #6973

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented May 28, 2018

Description

Related issues: #3955, #6594.
Similar: #6658, #6756, #6758, #6828.

This PR tries to provide Lerna setup similar to what we have in WordPress/packages. This would allow publishing source code of individual modules to npm to make them available for all plugin developers.

After moving date and element (and soon data), extracting dom from utils this PR extracts blob module and puts it into packages folder maintained by Lerna. This is a prerequisite for moving blocks module to npm packages structure.

How has this been tested?

Manually:

  • Removed node_modules folder.
  • npm install
  • npm test
  • npm run dev
  • npm run build
  • npm run package-plugin

Types of changes

Refactoring.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo self-assigned this May 28, 2018

@gziolo gziolo added this to the 3.0 milestone May 28, 2018

@gziolo gziolo requested review from WordPress/gutenberg-core, youknowriad and iseulde May 28, 2018

@iseulde

Works for me!

@gziolo gziolo merged commit bfafd1b into master May 28, 2018

2 checks passed

codecov/project 46.48% (+0.03%) compared to 931181f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the add/blob-package branch May 28, 2018

@Shelob9 Shelob9 referenced this pull request May 29, 2018

Closed

Packages: Publish all modules as independent npm packages #3955

19 of 19 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment