New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with sticky toolbar border #6980

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented May 28, 2018

The merge of a more background color friendly UI introduced a regression where the bottom border of the toolbar was gone, to avoid stacking the transparent opacities:

screen shot 2018-05-28 at 14 49 03

This PR reintroduces the solid color, and the bottom border.

screen shot 2018-05-28 at 14 52 22

It's still friendly to colored backgrounds.

Fix regression with sticky toolbar border
The merge of a more background color friendly UI introduced a regression where the bottom border of the toolbar was gone, to avoid stacking the transparent opacities.

This PR reintroduces the solid color, and the bottom border. It's still friendly to colored backgrounds.

@jasmussen jasmussen added this to the 3.0 milestone May 28, 2018

@jasmussen jasmussen self-assigned this May 28, 2018

@jasmussen jasmussen requested review from iseulde and WordPress/gutenberg-core May 28, 2018

@iseulde

Looks good. Unsure how to test the dark theme.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented May 28, 2018

Thanks. Dark theme isn't yet surfaced, but the toolbar isn't inverted in that. I think this is a fine solution. Appreciate the review!

@jasmussen jasmussen merged commit 5220c70 into master May 28, 2018

2 checks passed

codecov/project 46.44% remains the same compared to e70ca43
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/toolbar-border-regression branch May 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment