New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter: Fix 'no results' message #6997

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
3 participants
@noisysocks
Member

noisysocks commented May 29, 2018

Fixes #6975.

screen shot 2018-05-29 at 16 43 21

The inserter should display some explanatory text when the user searches for a block but there is no block found.

This was first added in #4040 and then accidentally removed in #6636.

To test:

  1. Open the inserter
  2. Search for that which does not exist
  3. You should see a friendly error message
Inserter: Fix 'no results' message
The inserter should display some explanatory text when the user searches
for a block but there is no block found.
@youknowriad

LGTM 👍

@noisysocks noisysocks merged commit ce14a1c into master May 30, 2018

2 checks passed

codecov/project 46.48% remains the same compared to d28fc33
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@noisysocks noisysocks deleted the fix/no-results-message branch May 30, 2018

@mtias mtias added this to the 3.0 milestone Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment