New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Child Blocks feedback #7012

Merged
merged 7 commits into from May 30, 2018

Conversation

Projects
None yet
4 participants
@noisysocks
Member

noisysocks commented May 30, 2018

Addresses various feedback left by @aduth on #6753.

@noisysocks noisysocks added this to the 3.0 milestone May 30, 2018

@noisysocks noisysocks requested a review from aduth May 30, 2018

@gziolo

gziolo approved these changes May 30, 2018

👍

const SECONDS_PER_DAY = 24 * 3600;
const SECONDS_PER_WEEK = 7 * 24 * 3600;
const MILLISECONDS_PER_HOUR = 3600 * 1000;
const MILLISECONDS_PER_DAY = 24 * 3600 * 1000;

This comment has been minimized.

@gziolo

gziolo May 30, 2018

Member

Nit, those constants can use previous declarations:

const MILLISECONDS_PER_DAY = 24 * MILLISECONDS_PER_HOUR;
const MILLISECONDS_PER_WEEK = 7 * MILLISECONDS_PER_DAY;
@aduth

aduth approved these changes May 30, 2018

Thanks for considering the feedback 👍

@youknowriad youknowriad merged commit 65400ad into master May 30, 2018

2 checks passed

codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +53.53% compared to 8e7682b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/child-blocks-feedback branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment