New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Code Styles issues to the core-data module #7017

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented May 30, 2018

just small fixes to address #6939 (review)

I don't think we should introduce another lib just to pluralize names but maybe later if it becomes too complex.

@youknowriad youknowriad self-assigned this May 30, 2018

@youknowriad youknowriad requested a review from aduth May 30, 2018

@aduth

aduth approved these changes May 30, 2018

👍

@youknowriad youknowriad merged commit 86a4b22 into master May 30, 2018

2 checks passed

codecov/project 46.46% (+0%) compared to 29092ae
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad added this to the 3.0 milestone May 30, 2018

@youknowriad youknowriad deleted the fix/codestyle branch May 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment