New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in Spacer block #7024

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented May 30, 2018

This PR fixes a regression introduced in 59f2ad8, which made the resizing dots disappear from the spacer block. You could still resize, there just weren't any visual handles. This fixes that.

There was a typo in the rename of the drag handle and associated CSS class.

screen shot 2018-05-30 at 19 13 13

Fix regression in Spacer block
There was a typo in the rename of the drag handle and associated CSS class.

@jasmussen jasmussen added this to the 3.0 milestone May 30, 2018

@jasmussen jasmussen self-assigned this May 30, 2018

@jasmussen jasmussen requested review from mtias and afercia May 30, 2018

@@ -47,8 +47,8 @@ export const settings = {
} }
minHeight="20"
handleClasses={ {
top: 'core-blocks-spacer__resize-handler-top',
bottom: 'core-blocks-spacer__resize-handler-bottom',
top: 'block-spacer__resize-handler-top',

This comment has been minimized.

@youknowriad

youknowriad May 30, 2018

Contributor

I think you should update the stylesheet instead ;) These class names do not follow our guidelines ;)

This comment has been minimized.

@jasmussen

jasmussen May 30, 2018

Contributor

Sorry, I'm about to hop on a meeting, if you have bandwidth feel free to commandeer this PR :D

Change classnames in the CSS not the JS
The JS followed guidelines.
@aduth

aduth approved these changes May 30, 2018

Confirmed working 👍

@jasmussen jasmussen merged commit eb4fc18 into master May 30, 2018

2 checks passed

codecov/project 46.43% (+<.01%) compared to 86a4b22
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/spacer-regression branch May 30, 2018

@afercia

This comment has been minimized.

Contributor

afercia commented May 30, 2018

Sorry, that was a last-minute change I haven't checked properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment