New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Drop deprecations slated for 3.0 removal #7031

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@aduth
Member

aduth commented May 30, 2018

This pull request seeks to remove deprecations slated for removal in the upcoming 3.0.0 release.

Specifically, this includes:

  • Block API: wp.blocks.registerCoreBlocks removed
  • RichText: Blind TinyMCE event forwarding removed

See: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-0-0

Testing instructions:

Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.

@@ -249,7 +249,6 @@ function gutenberg_register_scripts_and_styles() {
'wp-blocks',
'wp-components',
'wp-core-data',

This comment has been minimized.

@gziolo

gziolo May 31, 2018

Member

I noticed that core-blocks no longer depends on deprecated.

@@ -25,7 +25,7 @@ import createSelector from 'rememo';
import { serialize, getBlockType, getBlockTypes, hasBlockSupport } from '@wordpress/blocks';
import { __ } from '@wordpress/i18n';
import { moment } from '@wordpress/date';
import { deprecated } from '@wordpress/utils';
import deprecated from '@wordpress/deprecated';

This comment has been minimized.

@gziolo

gziolo May 31, 2018

Member

I included this fix to avoid double warning :)

@gziolo

gziolo approved these changes May 31, 2018

LGTM 🚢

@gziolo gziolo merged commit 72f4ca8 into master May 31, 2018

2 checks passed

codecov/project 46.43% (+<.01%) compared to eb4fc18
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the remove/3-0-deprecations branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment