New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Tooling: Avoid using spread for objects to work with all node 8x versions #7043

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented May 31, 2018

Description

Fixes issue raised by @jasmussen:

Could this PR have broken npm install for me? I'm getting this error:

screen shot 2018-05-31 at 09 51 15

How has this been tested?

npm install
npm run dev
npm run build

All of them should work on Node 8.2.x.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added this to the 3.0 milestone May 31, 2018

@gziolo gziolo self-assigned this May 31, 2018

@gziolo gziolo requested a review from jasmussen May 31, 2018

@gziolo gziolo added the [Type] Bug label May 31, 2018

@jasmussen

Confirmed, this fixes it for me!

@gziolo gziolo merged commit 6c8ab9b into master May 31, 2018

2 checks passed

codecov/project 46.43% remains the same compared to ed26e0f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the fix/babel-config-packages branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment