New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drag handle from breadcrumb #7083

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
3 participants
@jasmussen
Contributor

jasmussen commented Jun 1, 2018

Per feedback in #6773 (comment), it seems the drag handle for the breadcrumb was premature. Although it works on the edge, it's not consistent and was a bad idea.

This simply removes the grab handle. I will open a separate ticket for making that work.

Remove drag handle from breadcrumb
Per feedback in #6773 (comment), it seems the drag handle for the breadcrumb was premature. Although it works on the edge, it's not consistent and was a bad idea.

This simply removes the grab handle. I will open a separate ticket for making that work.

@jasmussen jasmussen self-assigned this Jun 1, 2018

@jasmussen jasmussen requested review from iseulde and WordPress/gutenberg-core Jun 1, 2018

@jasmussen jasmussen added this to the 3.0 milestone Jun 1, 2018

@iseulde

This comment has been minimized.

Member

iseulde commented Jun 1, 2018

@jasmussen So I seem to be able to drag paragraphs but for some reason no lists.

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Jun 1, 2018

I think your point was good, though, as it's not consistent. It would be good to make consistent separately, but get this interim fix in, in the mean time, I think.

@mtias

mtias approved these changes Jun 1, 2018

@jasmussen jasmussen merged commit 5099503 into master Jun 1, 2018

2 checks passed

codecov/project 46.32% remains the same compared to 0b32451
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iseulde

This comment has been minimized.

Member

iseulde commented Jun 1, 2018

Sorry for the nitpicking, this is probably unrelated to the labels now: there's a super tiny area that is draggable and I don't really understand why it is right there and why so small.

drag-label

@iseulde iseulde deleted the remove/label-grab-handle branch Jun 1, 2018

@jasmussen

This comment has been minimized.

Contributor

jasmussen commented Jun 1, 2018

There's an area around the whole block, centered on the border, and wider on the sides, that's draggable.

@iseulde

This comment has been minimized.

Member

iseulde commented Jun 1, 2018

@jasmussen Right, but there's nothing around the upper border. It's a 1-2px area or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment