New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drop-cap design to better balance line length. #7089

Merged
merged 1 commit into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@mtias
Contributor

mtias commented Jun 1, 2018

Our current drop-cap occupies just two lines of the paragraph, which feels unbalanced compared to the default length of the word line.

image

@karmatosed karmatosed added this to the 3.1 milestone Jun 4, 2018

@karmatosed karmatosed self-requested a review Jun 4, 2018

@karmatosed

I like this change, we'd have to review across devices but it seems like a good one to me design wise.

@mtias mtias merged commit e22cfd1 into master Jun 13, 2018

2 checks passed

codecov/project 46.35% remains the same compared to 4372d4c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the update/drop-cap-visual branch Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment