New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows-unfriendly theme.scss loader rule #7093

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@brandonpayton
Member

brandonpayton commented Jun 1, 2018

Description

The webpack module loader rule for theme.scss files contained a unix-style path separator that resulted in theme.scss not being matched with the ExtractTextPlugin and processed by SASS. Instead, it was being treated as a JS import, and our stub core-blocks/separator/theme.scss file happens to also parse as JS. This meant there was no build error but also no build/core-blocks/theme.css file when building in Windows. This commit simply removes the offending separator because it is unnecessary.

Fixes #7064.

How has this been tested?

I ran the build in the following environments and noted that build/core-blocks/theme.css and its rtl variant are created.

  • Windows 10, Command Prompt
  • Windows 10, Git Bash terminal
  • macOS

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Fix Windows-unfriendly theme.scss loader rule
The webpack module loader rule for theme.scss files contained a
unix-style path separator that resulted in theme.scss not being matched
with the ExtractTextPlugin and processed by SASS. Instead, it was being
treated as a JS import, and our stub `core-blocks/separator/theme.scss`
file happens to also parse as JS.  This meant there was no build error
but also no `build/core-blocks/theme.css` file. This commit simply
removes the offending separator because it is unnecessary.

@brandonpayton brandonpayton requested a review from aduth Jun 1, 2018

@aduth

aduth approved these changes Jun 1, 2018

👍

@brandonpayton brandonpayton merged commit 20293c4 into master Jun 1, 2018

2 checks passed

codecov/project 46.35% remains the same compared to a430f70
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brandonpayton brandonpayton deleted the fix/missing-theme-css-in-windows branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment