New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mousetrap to 1.6.2 #7103

merged 1 commit into from Jun 4, 2018


None yet
2 participants

pento commented Jun 3, 2018

As part of #6508, we found that the mousetrap library had an Apache 2.0 license, which is not compatible with GPL2.

The mousetrap author has kindly agreed to add the LLVM exception to the license, making it GPL2 compatible.

This is the only change in the mousetrap 1.6.2 release.

@pento pento added the [Type] Task label Jun 3, 2018

@pento pento added this to the 3.0 milestone Jun 3, 2018

@pento pento self-assigned this Jun 3, 2018

@pento pento requested a review from WordPress/gutenberg-core Jun 3, 2018


I am not a lawyer, but looks good to me 😆


This comment has been minimized.


pento commented Jun 4, 2018

Real lawyers wrote the language, so I'm not going to second guess them. 🙂

@pento pento merged commit b8c1f6d into master Jun 4, 2018

2 checks passed

codecov/project 46.35% remains the same compared to 23f8945
continuous-integration/travis-ci/pr The Travis CI build passed

@pento pento deleted the fix/upgrade-mousetrap branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment