New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme the hover outlines #7111

Merged
merged 1 commit into from Jun 6, 2018

Conversation

@jasmussen
Contributor

jasmussen commented Jun 4, 2018

This PR uses the admin color scheme to theme the outline hover style.

Screenshots:

screen shot 2018-06-04 at 08 53 01
screen shot 2018-06-04 at 08 52 48
screen shot 2018-06-04 at 08 53 11
screen shot 2018-06-04 at 08 53 19
screen shot 2018-06-04 at 08 54 59
screen shot 2018-06-04 at 08 55 08
screen shot 2018-06-04 at 08 55 19
screen shot 2018-06-04 at 08 56 40

Theme the hover outlines
This PR uses the admin color scheme to theme the outline hover style.

@jasmussen jasmussen self-assigned this Jun 4, 2018

@jasmussen jasmussen requested review from karmatosed and WordPress/gutenberg-core Jun 4, 2018

@karmatosed

Great little touch.

@noisysocks

Cool change. Code looks good!

},
'admin-color-sunrise': {
primary: '#d1864a',
secondary: '#c8b03c',
toggle: '#c8b03c',
button: '#d1864a',
outlines: '#AA652C',

This comment has been minimized.

@noisysocks

noisysocks Jun 5, 2018

Member

nit: We should lowercase these strings for consistency 🙂

@@ -48,49 +48,57 @@ const extractConfig = {
secondary: '#11a0d2',
toggle: '#11a0d2',
button: '#0085ba',
outlines: '#007cba',
},
themes: {

This comment has been minimized.

@tofumatt

tofumatt Jun 5, 2018

Member

Unrelated to this PR, but it seems weird we put themes in the webpack config. Any context for why we do that or should I make an issue to move 'em out?

This comment has been minimized.

@youknowriad

youknowriad Jun 5, 2018

Contributor

We put theme here to automatically generate the required CSS files using a post-css plugin #6739

This comment has been minimized.

@tofumatt

tofumatt Jun 5, 2018

Member

Right, it might be nice to move them to another file though? It doesn't really seem like config to me. 🤷‍♂️

This comment has been minimized.

@youknowriad

youknowriad Jun 5, 2018

Contributor

We can already use postcss.config.js and move all the config their. I personally don't like the proliferation of root level config files, but no strong opinion.

@jasmussen jasmussen added this to the 3.1 milestone Jun 6, 2018

@jasmussen jasmussen merged commit 6aed4cb into master Jun 6, 2018

2 checks passed

codecov/project 46.35% remains the same compared to 6a7085b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the try/themed-hover-outlines branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment