New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid loading Gutenberg assets in other admin pages #7117

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Jun 4, 2018

This introduces a is_gutenberg_page helper used to ensure Gutenberg assets are only loaded when necessary.

Testing instructions

  • Open any admin page, check that Gutenberg assets are not being loaded.

@youknowriad youknowriad self-assigned this Jun 4, 2018

@youknowriad youknowriad requested a review from mtias Jun 4, 2018

@noisysocks

This looks good. I tested locally and:

Gutenberg still loads on posts
Gutenberg still loads on pages
Gutenberg still loads on CPTs
Gutenberg styles are still applied on the frontend
Gutenberg isn't loaded on e.g. the WP dashboard

*
* @return boolean Whether Gutenberg is being loaded.
*
* @since 3.0.0

This comment has been minimized.

@noisysocks

noisysocks Jun 6, 2018

Member

Should this be 3.1.0?

@youknowriad youknowriad added this to the 3.1 milestone Jun 6, 2018

@youknowriad youknowriad merged commit 4ec4177 into master Jun 6, 2018

2 checks passed

codecov/project 46.48% remains the same compared to 7e64e1d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/avoid-loading-gutenberg-assets-in-wpadmin branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment