Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Verify if block icon background and foreground colors are readable #7125
If the color combination is not readable, a warning is shown in the developer console.
How has this been tested?
Verify that if the block just sets a background color like https://gist.github.com/jorgefilipecosta/2dd281f9f5f078258f7c8d4ba4cc34cd things work as before.
Verify that if the blocks set a pair of unreadable colors e.g: https://gist.github.com/jorgefilipecosta/3118c641e46fe0bea146877109ccb3af a warning is shown.
Verify that if the blocks set background and foreground colors that are readable no warning is shown https://gist.github.com/jorgefilipecosta/a2eb7c940e008e351f96aadf7ccbd999.
It is likely quite confusing for a user who doesn't have the developer console open to be selecting a colour and have it not take (with a different colour selected) with no message. Should we add some kind of notice more visible to the user for this?
Hi @tofumatt thank for the review, I updated the code, now when colors are not readable, we show a warning in the console and but we don't choose another color. This is more in line with decisions made in other places like the color palette warnings.