New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'who'=>'authors' compatibility shim #7158

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
2 participants
@danielbachhuber
Member

danielbachhuber commented Jun 5, 2018

This patch landed in WordPress 4.9.6, which is now Gutenberg's minimum
supported version. See https://core.trac.wordpress.org/ticket/42202

Removing code, woo hoo!

Remove 'who'=>'authors' compatibility shim
This patch landed in WordPress 4.9.6, which is now Gutenberg's minimum
supported version. See https://core.trac.wordpress.org/ticket/42202

Removing code, woo hoo!

@danielbachhuber danielbachhuber added this to the 3.1 milestone Jun 5, 2018

@danielbachhuber danielbachhuber requested a review from WordPress/gutenberg-core Jun 5, 2018

@aduth

This comment has been minimized.

Member

aduth commented Jun 11, 2018

How can I test this?

@aduth

aduth approved these changes Jun 11, 2018

Testing instructions:

  • Verify that the Author dropdown is presented and only includes options for valid authors (where author is a user who meets criteria defined here)

@danielbachhuber danielbachhuber merged commit 681aaed into master Jun 11, 2018

2 checks passed

codecov/project 46.48% remains the same compared to e86d7b6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the remove-who-authors branch Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment